Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #687 with a rowspan issue #716

Merged

Conversation

erickok
Copy link
Collaborator

@erickok erickok commented May 31, 2021

Also prevents crashes on edge cases where the rowspan or colspans are inconsistent/wrong

Also prevents crashes on edge cases where the rowspan or colspans are inconsistent/wrong
Copy link
Collaborator

@tneotia tneotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't know the columnMax + 1 was actually an error in code.

@erickok
Copy link
Collaborator Author

erickok commented May 31, 2021

@ryan-berger could you merge?

Copy link
Collaborator

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryan-berger ryan-berger merged commit d523e56 into Sub6Resources:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants