Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reset color bug #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix reset color bug #179

wants to merge 2 commits into from

Conversation

xuzhi2021
Copy link

  1. Because resetAppColor() sortNeeded=(dbutils.getsortstypes ()==SORT_BY_COLOR) is usually false, it passes the parameter sortNeeded=false to addAppAfterReset method. Then it will not call sortApps() and not refresh UI.
  2. If the parameter sortNeeded is passed true from resetAppColor(), the effect will be the same as "Reset All". Because the original size is not preserved.
    After solving thiese two problems and manually testing the effect, "Reset Color" resets the app text color without changing its size. successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review-Pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuzhi2021 @SubhamTyagi