Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requests by SBTRequestMatch #185

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Remove requests by SBTRequestMatch #185

merged 7 commits into from
Sep 13, 2023

Conversation

tcamin
Copy link
Member

@tcamin tcamin commented Sep 12, 2023

As per title.

This PR contains breaking change which will require a major version bump.

Stubbing requests follows LIFO order and there could potentially be 2 active stubs on the same request with different responses. The previous dictionary based setup couldn't properly return the entire list of active stubs.
@tcamin tcamin merged commit 49fe753 into master Sep 13, 2023
1 check passed
@tcamin tcamin deleted the feature/remove_by_stub branch September 13, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants