Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SublimeLinter-contrib-flog #136

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

icnagy
Copy link
Contributor

@icnagy icnagy commented Dec 29, 2023

Add plugin for flog.

@kaste
Copy link
Contributor

kaste commented Dec 29, 2023

Hi. Overall good, there is one issue though:

You write

    cmd = ('flog', '${file}')
    tempfile_suffix = 'rb'

That would mean the linter should run on temporary files but then cmd should also reference the tempfile like so:

    cmd = ('flog', '${temp_file}')

If the linter should run on the real/saved files only, you instead do

    cmd = ('flog', '${file_on_disk}')
    tempfile_suffix = '-'

I think you more or less mixed both variants.

@icnagy
Copy link
Contributor Author

icnagy commented Dec 30, 2023

@kaste Thanks for the feedback! Updated the command to use the temporary file.

@kaste
Copy link
Contributor

kaste commented Dec 30, 2023

Great, let's go. 🚢

@kaste kaste merged commit ed4c435 into SublimeLinter:master Dec 30, 2023
1 check passed
@icnagy icnagy deleted the add-sublimelinter-contrib-flog branch December 30, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants