Telaria Bid Adapter: add adCode & srcPageUrl query string param only …

…once. (prebid#4833) * Set srcPageUrl only once. * Set adCode only once.
SublimeSkinz · Mar 5, 2020 · 5aa2f09 · 5aa2f09
1 parent e959532
commit 5aa2f09
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 12 deletions.
diff --git a/modules/telariaBidAdapter.js b/modules/telariaBidAdapter.js
@@ -119,8 +119,8 @@ export const spec = {
   }
 };
 
-function getSrcPageUrl(params) {
-  return (params && params['srcPageUrl']) || encodeURIComponent(document.location.href);
+function getDefaultSrcPageUrl() {
+  return encodeURIComponent(document.location.href);
 }
 
 function getEncodedValIfNotEmpty(val) {
@@ -175,7 +175,10 @@ export const getTimeoutUrl = function(timeoutData) {
   if (!utils.isEmpty(params)) {
     let url = `https://${EVENTS_ENDPOINT}`;
 
-    url += `?srcPageUrl=${getSrcPageUrl(params)}`;
+    params = Object.assign({
+      srcPageUrl: getDefaultSrcPageUrl()
+    }, params);
+
     url += `${getUrlParams(params)}`;
 
     url += '&hb=1&evt=TO';
@@ -221,9 +224,12 @@ function generateUrl(bid, bidderRequest) {
       url += (`&playerHeight=${height}`);
     }
 
-    url += `${getUrlParams(bid.params, bid.schain)}`;
+    const params = Object.assign({
+      srcPageUrl: getDefaultSrcPageUrl()
+    }, bid.params);
+    delete params.adCode;
 
-    url += `&srcPageUrl=${getSrcPageUrl(bid.params)}`;
+    url += `${getUrlParams(params, bid.schain)}`;
 
     url += (`&transactionId=${bid.transactionId}`);
 

diff --git a/test/spec/modules/telariaBidAdapter_spec.js b/test/spec/modules/telariaBidAdapter_spec.js
@@ -118,7 +118,7 @@ describe('TelariaAdapter', () => {
   });
 
   describe('buildRequests', () => {
-    const stub = [{
+    const stub = () => ([{
       mediaTypes: {
         video: {
           playerSize: [[640, 480]],
@@ -131,7 +131,7 @@ describe('TelariaAdapter', () => {
         adCode: 'ssp-!demo!-lufip',
         videoId: 'MyCoolVideo'
       }
-    }];
+    }]);
 
     const schainStub = REQUEST_WITH_SCHAIN;
 
@@ -140,12 +140,12 @@ describe('TelariaAdapter', () => {
     });
 
     it('requires supply code & ad code to make a request', () => {
-      const tempRequest = spec.buildRequests(stub, BIDDER_REQUEST);
+      const tempRequest = spec.buildRequests(stub(), BIDDER_REQUEST);
       expect(tempRequest.length).to.equal(1);
     });
 
     it('generates an array of requests with 4 params, method, url, bidId and vastUrl', () => {
-      const tempRequest = spec.buildRequests(stub, BIDDER_REQUEST);
+      const tempRequest = spec.buildRequests(stub(), BIDDER_REQUEST);
 
       expect(tempRequest.length).to.equal(1);
       expect(tempRequest[0].method).to.equal('GET');
@@ -155,15 +155,15 @@ describe('TelariaAdapter', () => {
     });
 
     it('doesn\'t require player size but is highly recommended', () => {
-      let tempBid = stub;
+      let tempBid = stub();
       tempBid[0].mediaTypes.video.playerSize = null;
       const tempRequest = spec.buildRequests(tempBid, BIDDER_REQUEST);
 
       expect(tempRequest.length).to.equal(1);
     });
 
     it('generates a valid request with sizes as an array of two elements', () => {
-      let tempBid = stub;
+      let tempBid = stub();
       tempBid[0].mediaTypes.video.playerSize = [640, 480];
       tempBid[0].params.adCode = 'ssp-!demo!-lufip';
       tempBid[0].params.supplyCode = 'ssp-demo-rm6rh';
@@ -172,7 +172,7 @@ describe('TelariaAdapter', () => {
     });
 
     it('requires ad code and supply code to make a request', () => {
-      let tempBid = stub;
+      let tempBid = stub();
       tempBid[0].params.adCode = null;
       tempBid[0].params.supplyCode = null;
 
@@ -188,6 +188,32 @@ describe('TelariaAdapter', () => {
       let builtRequests = spec.buildRequests(tempBid, BIDDER_REQUEST);
       expect(builtRequests.length).to.equal(1);
     });
+
+    it('adds adUnitCode to the request url', () => {
+      const builtRequests = spec.buildRequests(stub(), BIDDER_REQUEST);
+
+      expect(builtRequests.length).to.equal(1);
+      const parts = builtRequests[0].url.split('adCode=');
+      expect(parts.length).to.equal(2);
+    });
+
+    it('adds srcPageUrl to the request url', () => {
+      const builtRequests = spec.buildRequests(stub(), BIDDER_REQUEST);
+
+      expect(builtRequests.length).to.equal(1);
+      const parts = builtRequests[0].url.split('srcPageUrl=');
+      expect(parts.length).to.equal(2);
+    });
+
+    it('adds srcPageUrl from params to the request only once', () => {
+      const tempBid = stub();
+      tempBid[0].params.srcPageUrl = 'http://www.test.com';
+      const builtRequests = spec.buildRequests(tempBid, BIDDER_REQUEST);
+
+      expect(builtRequests.length).to.equal(1);
+      const parts = builtRequests[0].url.split('srcPageUrl=');
+      expect(parts.length).to.equal(2);
+    });
   });
 
   describe('interpretResponse', () => {