Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL-1780: Fix pubtimeout #32

Merged
merged 8 commits into from
Jul 12, 2021
Merged

DL-1780: Fix pubtimeout #32

merged 8 commits into from
Jul 12, 2021

Conversation

o3LL
Copy link

@o3LL o3LL commented Jul 6, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

test/spec/modules/sublimeBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/sublimeBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/sublimeBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/sublimeBidAdapter_spec.js Show resolved Hide resolved
test/spec/modules/sublimeBidAdapter_spec.js Show resolved Hide resolved
@o3LL o3LL merged commit 613962f into sublime-adapter Jul 12, 2021
@o3LL o3LL deleted the DL-1780/fix-pubtimeout branch July 12, 2021 09:37
fgcloutier pushed a commit that referenced this pull request Aug 6, 2021
…ata (prebid#7167)

* DL-1746: Remove trId and use notid instead (#31)

* Remove trId and use notid instead
* Update version to 0.7.3
* Set default value to empty string

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>

* DL-1780: Fix pubtimeout (#32)

* Update timeout value with onTimeout data
* Add test for onTimeout
* Update state with timeout asap

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants