Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove metric from performance #213

Merged
merged 9 commits into from
May 11, 2023
Merged

chore: remove metric from performance #213

merged 9 commits into from
May 11, 2023

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented May 9, 2023 •
edited
Loading

@ThibaultFy
remove metric
ae8599e 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy
remove metric
8791d1c 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy
remove metric
ea0c7f3 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the remove-metric-from-performance branch from 389a181 to ea0c7f3 Compare May 9, 2023 14:49
@ThibaultFy
remove metric
7a27028 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the remove-metric-from-performance branch from 1172495 to 7a27028 Compare May 9, 2023 15:16
@ThibaultFy
remove metric
19d68cf 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the remove-metric-from-performance branch from c4b5da9 to 19d68cf Compare May 9, 2023 15:19
@ThibaultFy
remove metric
940e8c4 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the remove-metric-from-performance branch from f86eb20 to 940e8c4 Compare May 9, 2023 15:42
This was referenced May 9, 2023
Merged
Merged
@ThibaultFy
Copy link
Member Author

/e2e --help

@Owlfred
Copy link
Contributor

Owlfred commented May 9, 2023 

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                                         Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: hlf-k8s, orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>                 Comma-separated list of tests to run. Valid options: sdk,substrafl,frontend or NONE. (default: "sdk")
  --benchmarks-to-run, --benchmarks <benchmarks-to-run>  Comma-separated list of workflows tests to run. Valid options: mnist, camelyon or NONE. (default: "NONE")
  --orchestrator-mode, --mode <orchestrator-mode>        Comma-separated list of orchestrator modes to run tests for. Valid options: standalone,distributed (default: "standalone,distributed")
  -h, --help                                             display help for command

@ThibaultFy
Copy link
Member Author

/e2e --refs substra=remove-metric-from-performance,orchestrator=remove-metric-from-performance,substra-backend=remove-metric-from-performance

@Owlfred
Copy link
Contributor

Owlfred commented May 9, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Tests Benchmark: ⏭️
  • Tests Distributed: ❌
  • Tests Standalone: ❌

“I’m sorry, Dave. I’m afraid I can’t do that.” ― Hal, 2001: A Space Odyssey

@ThibaultFy
Copy link
Member Author

/e2e --refs substra=remove-metric-from-performance,orchestrator=remove-metric-from-performance,substra-backend=remove-metric-from-performance

@Owlfred
Copy link
Contributor

Owlfred commented May 10, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

@ThibaultFy
changelog
1c5a3d3 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the remove-metric-from-performance branch from 02b8967 to 1c5a3d3 Compare May 10, 2023 15:22
@ThibaultFy ThibaultFy marked this pull request as ready for review May 10, 2023 15:29
@ThibaultFy ThibaultFy requested a review from a team as a code owner May 10, 2023 15:29
SdgJlbl
SdgJlbl reviewed May 11, 2023
View reviewed changes
server/standalone/migration/000057_remove-metric-from-performance.up.sql Outdated
Comment on lines 2 to 3
/* To keep differiantiability regarding the performances, we update the output identifier to the metric name */
/* on previous performances */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove?

SdgJlbl
SdgJlbl approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThibaultFy
rm comment
25876d7 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the remove-metric-from-performance branch from 0c8e46b to 25876d7 Compare May 11, 2023 08:25
@ThibaultFy @github-actions
[auto] generate database diagram
9670721 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ThibaultFy ThibaultFy merged commit 564520e into main May 11, 2023
@ThibaultFy ThibaultFy deleted the remove-metric-from-performance branch May 11, 2023 08:29
@Milouu Milouu mentioned this pull request May 11, 2023
Merged
Milouu added a commit that referenced this pull request May 15, 2023
@Milouu
chore: release 0.34.0 (#214)
f8dd1b0 
## [0.34.0](https://github.com/Substra/orchestrator/releases/tag/0.34.0)
- 2023-05-11

### Changed

- A Performance in now unique regarding a compute task key, a metric key
and a compute task output identifier
([#197](#197))

### Removed

- Metric from Performance
([#213](#213))

Signed-off-by: Milouu <milan.roustan@owkin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @SdgJlbl