Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated ioutil package with os #269

Merged
merged 2 commits into from
Aug 31, 2023
Merged

chore: replace deprecated ioutil package with os #269

merged 2 commits into from
Aug 31, 2023

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Aug 31, 2023

Description

What is said in the title

How has this been tested?

Unit tests 🤞

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@SdgJlbl SdgJlbl requested a review from a team as a code owner August 31, 2023 12:59
@linear
Copy link

linear bot commented Aug 31, 2023

FL-1021 Replace deprecated package ioutil

Context

Source code review (the Audit page on Notion has links to the detailed report)

The ioutil package is still used in the Substra orchestrator. As of Go 1.16, the ioutil package is deprecated. The implementations in the package io or package os should further be used instead.

Specification

Looks like os has functions that are like ioutil's

Acceptance criteria

We no longer use ioutil in favor of more recent alternatives

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Aug 31, 2023

/e2e

@Owlfred
Copy link
Contributor

Owlfred commented Aug 31, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

oleobal
oleobal approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@oleobal oleobal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@SdgJlbl
chore: replace deprecated ioutil package with os
43d7bb6 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl
Changelog
34e64e5 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl force-pushed the sarahdiot-girard/fl-1021-replace-deprecated-package-ioutil branch from 70e9e47 to 34e64e5 Compare August 31, 2023 14:31
@SdgJlbl SdgJlbl enabled auto-merge (squash) August 31, 2023 14:32
@SdgJlbl SdgJlbl merged commit 635f535 into main Aug 31, 2023
8 checks passed
@SdgJlbl SdgJlbl deleted the sarahdiot-girard/fl-1021-replace-deprecated-package-ioutil branch August 31, 2023 14:33
@Milouu Milouu mentioned this pull request Sep 5, 2023
Merged
Milouu added a commit that referenced this pull request Sep 7, 2023
@Milouu
chore: release 0.36.0 (#273)
200e123 
### Changed

- Replace deprecated ioutil package with os
([#269](#269))

Signed-off-by: Milouu <milan.roustan@owkin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleobal oleobal oleobal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SdgJlbl @Owlfred @oleobal