Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove distributed skaffold profile and chaincode* images #319

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

thbcmlowk
Copy link
Contributor

@thbcmlowk thbcmlowk commented Oct 18, 2023

Issue

FL-1237

Description

  • Removed distributed Skaffold profile and mentions in README.md
  • Removed chaincode-init and chaincode docker images and workflows

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Needs

https://github.com/owkin/substra-ci/pull/133
Substra/substra-documentation#379

Related

Substra/substra-backend#768

@thbcmlowk thbcmlowk changed the title Chore/remove distributed skaffold chore: remove distributed skaffold profile Oct 18, 2023
@linear
Copy link

linear bot commented Oct 18, 2023

@Substra Substra deleted a comment from Owlfred Oct 19, 2023
@Substra Substra deleted a comment from Owlfred Oct 19, 2023
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
…he documentation

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
…d 'chaincode-init' images

Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk force-pushed the chore/remove-distributed-skaffold branch from 70601ae to eec7713 Compare October 19, 2023 08:09
@thbcmlowk
Copy link
Contributor Author

/e2e --tests=sdk

@Owlfred
Copy link
Contributor

Owlfred commented Oct 19, 2023

End to end tests: ✔️ SUCCESS

Awesome sauce!

@Substra Substra deleted a comment from Owlfred Oct 19, 2023
@Substra Substra deleted a comment from Owlfred Oct 19, 2023
@thbcmlowk thbcmlowk changed the title chore: remove distributed skaffold profile chore: remove distributed skaffold profile and chaincode* images Oct 19, 2023
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbcmlowk thbcmlowk merged commit 5dc63d4 into main Oct 24, 2023
7 checks passed
@thbcmlowk thbcmlowk deleted the chore/remove-distributed-skaffold branch October 24, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants