feat: add profiling steps #407
Conversation
|
/e2e --tests substra-backend=feat/add-profiling-step-functions |
changes/1519.added
Outdated
| @@ -0,0 +1,3 @@ | |||
| A new service called `ProfilingService` in charge of propagating profiling | |||
| - For now, only register and propagates profiling steps | |||
| - Introduce a new asset type, ASSET_PROFILING_STEP` | |||
There was a problem hiding this comment.
| - Introduce a new asset type, ASSET_PROFILING_STEP` | |
| - Introduce a new asset type, `ASSET_PROFILING_STEP` |
| message ProfilingStep { | ||
| uint32 duration = 1; | ||
| string asset_key = 2; | ||
| string step = 3; |
There was a problem hiding this comment.
I assume the last two items are Enum, but that there is no way of encoding that in protobuf?
| @@ -0,0 +1,2 @@ | |||
| INSERT INTO asset_kinds(kind) VALUES ('ASSET_PROFILING_STEP') | |||
There was a problem hiding this comment.
do we want to add a table to store the Enum with the profiling steps?
There was a problem hiding this comment.
That is the pattern we used for previous enums, and we didn't implemented the management of postgres enums in the code.
|
/e2e --tests substra-backend=feat/add-profiling-step-functions |
|
/e2e --tests substra-backend=feat/add-profiling-step-functions |
|
/e2e --tests substra-backend=feat/add-profiling-step-functions |
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/add-profiling-steps
branch
from
eb0ccef
to
4eb587e
Compare
|
/e2e --tests substra-backend=feat/add-profiling-step-functions |
|
End to end tests: ✔️ SUCCESS “Carpe diem. Seize the day, boys.” ― John Keating, Dead Poets Society |
|
/e2e --tests sdk,substrafl,frontend,documentation,mnist substra-backend=feat/add-profiling-step-functions |
|
End to end tests: ✔️ SUCCESS You rock! |
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Description
Allow transferring function profiling steps through the orchestrator, allowing the builder to register event without having to have http(s) requests to the backend api server (involving having access to the db to get credentials). This also allows having duration for the function available on every backend.
The drawback of this approach is, how it is relying on the event system already in place, the function profiling are also saved in the DB of the orchestrator.
Fixes FL-1519
Companion PR
How has this been tested?
Checklist