fix: check plan.IsTerminated on IsPlanRunning #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
|
/e2e --tests sdk,mnist |
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
ThibaultFy
commented
Jun 12, 2024
| @@ -703,10 +703,14 @@ func TestIsPlanRunning(t *testing.T) { | |||
| require.Nil(t, err) | |||
|
|
|||
| resp = appClient.IsPlanRunning("cp2") | |||
| require.True(t, resp.IsRunning) | |||
| require.False(t, resp.IsRunning) | |||
There was a problem hiding this comment.
@guilhem-barthes looks like that we where testing this use case and expecting it to be Running even after canceling it... We agree that we want it to be not running if canceled right ?
There was a problem hiding this comment.
Sounds about right
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
lib/service/computeplan.go
Outdated
| if plan.IsTerminated() { | ||
| return false, err | ||
| } else { | ||
| return s.GetComputePlanDBAL().IsPlanRunning(key) |
There was a problem hiding this comment.
Architecture wise, I feel like IsPlanRunning should be renamed
There was a problem hiding this comment.
On service side or dbal ?
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
|
/e2e --tests sdk,mnist |
|
End to end tests: ✔️ SUCCESS You rock! |
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
guilhem-barthes
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check is plan.terminated when calling IsPlanRunning instead of changing the status of the task, cause it does not change the behaviour of
IsPlanRunning(checked before changing task status).This PR revert a part of #427 and closes FL-1593