fix: replace Exception by RuntimeError as Exception does not ac…

…cept strign as first arg Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Substra · Sep 2, 2024 · c140143 · c140143
1 parent 39665f8
commit c140143
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/backend/substrapp/lock_local.py b/backend/substrapp/lock_local.py
@@ -47,7 +47,7 @@ def lock_resource(
             did_wait = True
             logger.debug("Lock: Waiting for lock to be released", lock_file=lock_file)
         if time.time() - start > timeout:
-            raise Exception(f"Failed to acquire lock after {timeout} seconds", lock_file=lock_file)
+            raise RuntimeError(f"Failed to acquire lock after {timeout} seconds", lock_file=lock_file)
         time.sleep(delay)
 
     logger.debug("Lock: Acquired", lock_file=lock_file)

diff --git a/backend/substrapp/tests/test_lock_local.py b/backend/substrapp/tests/test_lock_local.py
@@ -14,6 +14,6 @@ def test_lock_local_timeout():
     lock_path = Path(lock_local._get_lock_file_path(slug))
     lock_path.write_text("unique_id")
 
-    with pytest.raises(Exception):
+    with pytest.raises(RuntimeError):
         with lock_local.lock_resource(resource_type, unique_identifier, timeout=1):
             pass