Skip to content

Commit

Permalink
WIP fix Failure report handling when errors during remote function do…
Browse files Browse the repository at this point in the history
…wnload

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
  • Loading branch information
SdgJlbl committed Dec 14, 2023
1 parent f18ff36 commit cb46722
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions backend/substrapp/tasks/tasks_compute_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
from substrapp.compute_tasks.lock import MAX_TASK_DURATION
from substrapp.compute_tasks.lock import acquire_compute_plan_lock
from substrapp.compute_tasks.outputs import OutputSaver
from substrapp.exceptions import OrganizationHttpError
from substrapp.exceptions import OrganizationHttpError, OrganizationError
from substrapp.lock_local import lock_resource
from substrapp.orchestrator import get_orchestrator_client
from substrapp.tasks.task import ComputeTask
Expand Down Expand Up @@ -200,7 +200,13 @@ def _run(
image_builder.wait_for_image_built(ctx.function, channel_name)

if get_owner() != ctx.function.owner:
image_builder.load_remote_function_image(ctx.function, channel_name)
try:
image_builder.load_remote_function_image(ctx.function, channel_name)
except OrganizationHttpError as e:
raise compute_task_errors.CeleryNoRetryError() from e
except OrganizationError as e:
raise compute_task_errors.CeleryRetryError() from e


# stop build_image timer
_create_task_profiling_step(channel_name, task.key, ComputeTaskSteps.BUILD_IMAGE, timer.stop())
Expand Down

0 comments on commit cb46722

Please sign in to comment.