Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout on save_image #1003

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 30, 2024

Description

Fixes FL-1725

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Copy link

linear bot commented Sep 30, 2024

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 30, 2024

End to end tests: ❌ FAILURE

What a surprise... 🙄

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 30, 2024

End to end tests: ✔️ SUCCESS

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 30, 2024
@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 30, 2024 15:11
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 30, 2024 15:11
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests doc --refs substra-documentation=chore/bump-dependencies

@Owlfred
Copy link

Owlfred commented Oct 1, 2024

End to end tests: ✔️ SUCCESS

Woohoo! 🎉

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the feat/add-timeout-save-images branch from 00e8128 to a7310b8 Compare October 1, 2024 11:47
@guilhem-barthes guilhem-barthes enabled auto-merge (squash) October 1, 2024 11:47
@guilhem-barthes guilhem-barthes merged commit 8b45c58 into main Oct 1, 2024
10 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/add-timeout-save-images branch October 1, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compute-engine documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants