Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wait redis on start #1010

Merged
merged 6 commits into from
Oct 9, 2024
Merged

feat: wait redis on start #1010

merged 6 commits into from
Oct 9, 2024

Conversation

guilhem-barthes
Copy link
Contributor

Description

Fixes FL-1746

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Copy link

linear bot commented Oct 9, 2024

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend

@Owlfred
Copy link

Owlfred commented Oct 9, 2024

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon,frontend:
  • Dispatch Jobs: ✔️
  • Documentation / doc:
  • MNIST / mnist,frontend:
  • SubstraFL / substrafl,frontend:
  • SubstraSDK / sdk:

Not this time.

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the feat/wait-redis-on-start branch from d410887 to e4bbdb3 Compare October 9, 2024 09:24
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend

@Owlfred
Copy link

Owlfred commented Oct 9, 2024

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon,frontend:
  • Dispatch Jobs: ✔️
  • Documentation / doc:
  • MNIST / mnist,frontend:
  • SubstraFL / substrafl,frontend:
  • SubstraSDK / sdk:

“Houston, we have a problem.” ― Jim Lovell, Apollo 13

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend

@Owlfred
Copy link

Owlfred commented Oct 9, 2024

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon,frontend: ✔️
  • Dispatch Jobs: ✔️
  • Documentation / doc: ✔️
  • MNIST / mnist,frontend:
  • SubstraFL / substrafl,frontend: ✔️
  • SubstraSDK / sdk: ✔️

Oh well.

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend

@Owlfred
Copy link

Owlfred commented Oct 9, 2024

End to end tests: ✔️ SUCCESS

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend

@guilhem-barthes guilhem-barthes marked this pull request as ready for review October 9, 2024 12:44
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner October 9, 2024 12:44
@Owlfred
Copy link

Owlfred commented Oct 9, 2024

End to end tests: ✔️ SUCCESS

Booya!

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guilhem-barthes guilhem-barthes merged commit 2ff1696 into main Oct 9, 2024
10 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/wait-redis-on-start branch October 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants