Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: openshift compatibility #657

Closed
wants to merge 8 commits into from
Closed

Conversation

oleobal
Copy link
Collaborator

@oleobal oleobal commented May 19, 2023

Description

Writing on the root filesystem fails when readOnlyRootFilesystem is set, which is the case in some environments, such as OpenShift. This PR fixes this.

It also removes one permission we used to ask for, because it looks unused. 🤞

Depends on #668 being merged and released

Fixes FL-1000

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@oleobal
Copy link
Collaborator Author

oleobal commented May 19, 2023

/e2e

@Owlfred
Copy link

Owlfred commented May 19, 2023

End to end tests: ✔️ SUCCESS

@oleobal oleobal force-pushed the chore/openshift-compat branch 3 times, most recently from 5276c36 to 847cd48 Compare June 5, 2023 12:42
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 5, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jun 5, 2023
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Also pretty up some resources..

Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
@linear
Copy link

linear bot commented Jun 5, 2023

@oleobal
Copy link
Collaborator Author

oleobal commented Jun 13, 2023

Replaced with #671, I'd like to keep using chore/openshift-compat for developing on that environment rather than keeping it ready for review & merging

@oleobal oleobal closed this Jun 13, 2023
@oleobal oleobal changed the title chore: stop writing on root filesystem chore: openshift compatibility Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants