-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: openshift compatibility #657
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/e2e |
End to end tests: ✔️ SUCCESS |
oleobal
force-pushed
the
chore/openshift-compat
branch
3 times, most recently
from
June 5, 2023 12:42
5276c36
to
847cd48
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jun 5, 2023
2 tasks
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Jun 5, 2023
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Also pretty up some resources.. Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
oleobal
force-pushed
the
chore/openshift-compat
branch
from
June 5, 2023 16:12
0100bf4
to
0c2247d
Compare
2 tasks
Replaced with #671, I'd like to keep using |
oleobal
changed the title
chore: stop writing on root filesystem
chore: openshift compatibility
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writing on the root filesystem fails when
readOnlyRootFilesystem
is set, which is the case in some environments, such as OpenShift. This PR fixes this.It also removes one permission we used to ask for, because it looks unused. 🤞
Depends on #668 being merged and released
Fixes FL-1000
Checklist