Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: making secret key configurable and reorganizing settings #674

Closed
wants to merge 1 commit into from

Conversation

oleobal
Copy link
Collaborator

@oleobal oleobal commented Jun 20, 2023

Description

This reverts #688

How has this been tested?

See e2e ⬇️

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@oleobal
Copy link
Collaborator Author

oleobal commented Jun 20, 2023

/e2e --tests sdk,frontend

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 20, 2023
@oleobal
Copy link
Collaborator Author

oleobal commented Jun 20, 2023

/e2e --help

@Owlfred
Copy link

Owlfred commented Jun 20, 2023

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                                         Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: hlf-k8s, orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>                 Comma-separated list of tests to run. Valid options: sdk,substrafl,frontend or NONE. (default: "sdk")
  --benchmarks-to-run, --benchmarks <benchmarks-to-run>  Comma-separated list of workflows tests to run. Valid options: mnist, camelyon or NONE. (default: "NONE")
  --orchestrator-mode, --mode <orchestrator-mode>        Comma-separated list of orchestrator modes to run tests for. Valid options: standalone,distributed (default: "standalone,distributed")
  -h, --help                                             display help for command

@oleobal
Copy link
Collaborator Author

oleobal commented Jun 20, 2023

OK, can you try again now you have time on your hands?

/e2e --tests sdk,frontend

@Owlfred
Copy link

Owlfred commented Jun 20, 2023

End to end tests: ✔️ SUCCESS

“Carpe diem. Seize the day, boys.” ― John Keating, Dead Poets Society

@oleobal oleobal mentioned this pull request Jun 20, 2023
2 tasks
…668)"

This reverts commit 41d6d09.

Refs: 41d6d09
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
@oleobal
Copy link
Collaborator Author

oleobal commented Jun 21, 2023

Closed in favour of #676

@oleobal oleobal closed this Jun 21, 2023
@SdgJlbl SdgJlbl deleted the revert/pr-668 branch July 31, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants