feat: add privateCa to kaniko pods #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
from
77ba711 to
765e880
Compare
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
from
765e880 to
15d3a48
Compare
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
from
15d3a48 to
de78344
Compare
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
2 times, most recently
from
cf74ebe to
5938472
Compare
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
from
5938472 to
8f2d0bf
Compare
ThibaultFy
changed the title
ThibaultFy
changed the title
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
from
7e8b1b2 to
f6acd68
Compare
github-actions
bot
added
the
documentation
|
/e2e --tests sdk |
|
End to end tests: ✔️ SUCCESS Yay! 🎉 |
ThibaultFy
commented
Apr 9, 2024
| @@ -284,6 +295,10 @@ def _build_container(dockerfile_mount_path: str, image_tag: str) -> kubernetes.c | |||
| ) | |||
| volume_mounts.append(docker_config) | |||
|
|
|||
| if PRIVATE_CA_ENABLED: | |||
| docker_config = kubernetes.client.V1VolumeMount(name=CA_SECRET_NAME, mount_path="/kaniko/ssl/certs") | |||
There was a problem hiding this comment.
@guilhem-barthes how the system knows that it must calls the file ca-certificates.crt ?
There was a problem hiding this comment.
That's the default for ssh configuration
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
ThibaultFy
force-pushed
the
add-cert-kaniko
branch
from
9f18cb5 to
e993cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes FL-1485
How has this been tested?
Checklist