Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add limits and requests configuration in values (#867) #892

Merged
merged 11 commits into from
Apr 26, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Apr 23, 2024

Description

closes FL-1547

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@ThibaultFy ThibaultFy force-pushed the chore/follow-up-requests-limits branch from cc964bd to e537054 Compare April 25, 2024 07:15
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy force-pushed the chore/follow-up-requests-limits branch 3 times, most recently from c885e19 to 8b9342a Compare April 25, 2024 13:10
@ThibaultFy
Copy link
Member Author

/e2e --tests camelyon

@Owlfred
Copy link

Owlfred commented Apr 25, 2024

End to end tests: ❌ FAILURE

Oh noes.

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy force-pushed the chore/follow-up-requests-limits branch from 8b9342a to babacf4 Compare April 25, 2024 13:15
@ThibaultFy
Copy link
Member Author

/e2e --tests camelyon

@Owlfred
Copy link

Owlfred commented Apr 25, 2024

End to end tests: ✔️ SUCCESS

@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from linear bot Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@Substra Substra deleted a comment from Owlfred Apr 25, 2024
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 25, 2024
@ThibaultFy
Copy link
Member Author

/e2e --tests camelyon,sdk,doc,mnist,substrafl,frontend

@Owlfred
Copy link

Owlfred commented Apr 25, 2024

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon,frontend: ✔️
  • Dispatch Jobs: ✔️
  • Documentation / doc: ✔️
  • MNIST / mnist,frontend: ✔️
  • SubstraFL / substrafl,frontend: ✔️
  • SubstraSDK / sdk:

“I’m sorry, Dave. I’m afraid I can’t do that.” ― Hal, 2001: A Space Odyssey

@Substra Substra deleted a comment from Owlfred Apr 25, 2024
@ThibaultFy
Copy link
Member Author

ThibaultFy commented Apr 25, 2024

Hybrid tests are currently down, consider CI as ✅

@ThibaultFy ThibaultFy marked this pull request as ready for review April 25, 2024 14:52
@ThibaultFy ThibaultFy requested a review from a team as a code owner April 25, 2024 14:52
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that!

@ThibaultFy ThibaultFy changed the title chore: profiles to add limits and requests to pods (#867) chore: add limits and requests configuration in values (#867) Apr 25, 2024
@ThibaultFy
Copy link
Member Author

@thbcmlowk have you carefully check what I did on the values file to add the prepopulate resources ? I added a section called registryPrepopulate with two container waiteRegistry and pause. I'm not sure about the naming nor the form...

@ThibaultFy ThibaultFy merged commit c7ca4a1 into main Apr 26, 2024
12 checks passed
@ThibaultFy ThibaultFy deleted the chore/follow-up-requests-limits branch April 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compute-engine documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants