feat: retry on timeout connections to external registry #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultFy
reviewed
May 31, 2024
Comment on lines
+169
to
176
| try: | ||
| image_exists = docker.container_image_exists(tag) | ||
| except Exception: | ||
| image_exists = False | ||
| if image_exists: | ||
| logger.warning( | ||
| f"Build of container image {tag} failed, probably because it was done by a concurrent build", | ||
| exc_info=True, |
There was a problem hiding this comment.
Suggested change
| try: | |
| image_exists = docker.container_image_exists(tag) | |
| except Exception: | |
| image_exists = False | |
| if image_exists: | |
| logger.warning( | |
| f"Build of container image {tag} failed, probably because it was done by a concurrent build", | |
| exc_info=True, | |
| try: | |
| if docker.container_image_exists(tag): | |
| logger.warning( | |
| f"Build of container image {tag} failed, probably because it was done by a concurrent build", | |
| exc_info=True, | |
| ) | |
| return | |
| except Exception: | |
| pass |
There was a problem hiding this comment.
I find it more explicit that way. Feel free to ignore
There was a problem hiding this comment.
I like to wrap the try except on the minimal number of lines, to mark explicitly what could potentially raise, and to avoid to mask unexpected Exceptions (even more when using a blanket except Exception).
I'm curious though, what do you find more explicit in your suggestion?
There was a problem hiding this comment.
I see your point. What I found more explicit is to not set image_exists = False cause it's never used afterwards, and to explicitely set the except Exception: pass to clearly indicate that we bypass all exceptions.
SdgJlbl
force-pushed
the
feat/fl-1569
branch
2 times, most recently
from
64b6c36
to
5fdf0a2
Compare
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
|
/e2e |
|
End to end tests: ✔️ SUCCESS Crushed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes fl-1569