New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom compute pod affinities, nodeSelector and tolerations #935

Merged

guilhem-barthes merged 22 commits into main from feat/allow-custom-compute-pod-affinities

Jul 23, 2024

Member

ThibaultFy commented Jun 21, 2024 •

edited by guilhem-barthes

Loading

Description

Fixes FL-1651

How has this been tested?

Checklist

changelog was updated with notable changes
documentation was updated

github-actions bot added the compute-engine label

ThibaultFy force-pushed the feat/allow-custom-compute-pod-affinities branch 2 times, most recently from 7545c37 to ff5ccc3 Compare

June 24, 2024 12:50

ThibaultFy commented

View reviewed changes

charts/substra-backend/values.yaml Outdated

+                        - key: statefulset.kubernetes.io/pod-name
+                          operator: In
+                          values:
+                          - $(HOSTNAME)

Member Author

ThibaultFy Jun 24, 2024

Yep I confirm ahah x)

guilhem-barthes reviewed

View reviewed changes

charts/substra-backend/values.yaml Outdated Show resolved Hide resolved

guilhem-barthes reviewed

View reviewed changes

charts/substra-backend/values.yaml Outdated Show resolved Hide resolved

guilhem-barthes reviewed

View reviewed changes

charts/substra-backend/values.yaml Outdated Show resolved Hide resolved

ThibaultFy force-pushed the feat/allow-custom-compute-pod-affinities branch 4 times, most recently from b3ef5e2 to 9342a05 Compare

June 25, 2024 13:13

ThibaultFy force-pushed the feat/allow-custom-compute-pod-affinities branch from 1ea9bc2 to 7c66407 Compare

July 3, 2024 14:25

ThibaultFy marked this pull request as ready for review

July 3, 2024 14:46

ThibaultFy requested a review from a team as a code owner

July 3, 2024 14:46

ThibaultFy force-pushed the feat/allow-custom-compute-pod-affinities branch from f989b57 to 2ea5624 Compare

July 8, 2024 07:11

ThibaultFy requested a review from guilhem-barthes

July 8, 2024 07:11

Member Author

ThibaultFy commented Jul 8, 2024

/e2e

Owlfred commented Jul 8, 2024 •

edited

Loading

End to end tests: ✔️ SUCCESS

Congratulations!

ThibaultFy marked this pull request as draft

July 9, 2024 16:11

thbcmlowk reviewed

View reviewed changes

backend/substrapp/clients/organization.py Outdated Show resolved Hide resolved

thbcmlowk reviewed

View reviewed changes

backend/substrapp/clients/organization.py Outdated Show resolved Hide resolved

thbcmlowk reviewed

View reviewed changes

backend/substrapp/clients/organization.py Outdated Show resolved Hide resolved

thbcmlowk reviewed

View reviewed changes

backend/substrapp/compute_tasks/execute.py Outdated Show resolved Hide resolved

thbcmlowk reviewed

View reviewed changes

backend/substrapp/compute_tasks/image_builder.py Outdated Show resolved Hide resolved

thbcmlowk reviewed

View reviewed changes

backend/substrapp/compute_tasks/image_builder.py Outdated Show resolved Hide resolved

Contributor

guilhem-barthes commented Jul 10, 2024

closes FL-1651

guilhem-barthes force-pushed the feat/allow-custom-compute-pod-affinities branch 3 times, most recently from 878e355 to 1388241 Compare

July 10, 2024 15:40

guilhem-barthes marked this pull request as ready for review

July 16, 2024 12:38

SdgJlbl reviewed

View reviewed changes

charts/substra-backend/values.yaml Show resolved Hide resolved

linear bot commented Jul 19, 2024

FL-1651 Add annotations to allow custom nodeSelectors, taints and selectors

Substra deleted a comment from linear bot

guilhem-barthes force-pushed the feat/allow-custom-compute-pod-affinities branch from 1388241 to b4d44d7 Compare

July 22, 2024 09:12

guilhem-barthes and others added 22 commits

July 23, 2024 11:37


          feat: create env var POD_NAME and COMPUTE_POD_AFFINITY to replace…

d6a0a5d

… dynamically generated pod affinity for compute pod

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>


          wip: use affinity from env var

20bb3e1

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>


          chore: affinite and access mode to values

823f6f8

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: add node selector and tolerations for compute pod

d633e52

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: typo yaml

54197a1

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: toYaml

37112e5

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: toYaml

abc8d42

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: podname to hostname

2918ab0

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          Update charts/substra-backend/values.yaml

5deffc7

Co-authored-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>


          chore: change access mode

2b07335

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: alpha release

ed3dc92

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: chart doc

f48c726

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: access modes

6c255ca

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: pass persistence.storageClass to backend chart

85f4bb3

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore(dev): remove storageClassName

8761f22

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: changelog

6581aba

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: add logging

40fa54c

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: more logs

77b2fdc

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: more logs

95581d6

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore(dev): bump to alpha.4 for more logs

c13c67b

Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>


          chore: remove debug logging

b78d8e4

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>


          feat: raise uncatched exceptions in `image_transfer/encoder.py::get_m…

8a13af2

…anifests_and_list_of_all_blobs`

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>

guilhem-barthes force-pushed the feat/allow-custom-compute-pod-affinities branch from b4d44d7 to 8a13af2 Compare

July 23, 2024 09:38

thbcmlowk approved these changes

View reviewed changes

guilhem-barthes merged commit 27621b7 into main

10 checks passed

guilhem-barthes deleted the feat/allow-custom-compute-pod-affinities branch

July 23, 2024 10:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels