Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(charts): allow using existing secret for redis #951

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat(charts): allow using existing secret for redis #951

merged 3 commits into from
Jul 12, 2024

Conversation

thbcmlowk
Copy link
Contributor

Description

Part of FL-1642

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@linear Linear
Copy link

linear bot commented Jul 10, 2024

FL-1642 Allow using pre-defined secrets in substra-backend

@thbcmlowk
feat(charts): allow using existing secret for redis
64f4e76 
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk force-pushed the chore/existing-secret-redis branch from 6d2748c to 0a59589 Compare July 11, 2024 08:18
@Substra Substra deleted a comment from Owlfred Jul 11, 2024
@thbcmlowk
chore(charts): bump chart version
3386439 
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk force-pushed the chore/existing-secret-redis branch from 0a59589 to 3386439 Compare July 11, 2024 08:30
@thbcmlowk
fix(helpers): default redis secret name
1f1e39b 
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk
Copy link
Contributor Author

/e2e

@Owlfred
Copy link

Owlfred commented Jul 11, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@Substra Substra deleted a comment from Owlfred Jul 11, 2024
@thbcmlowk thbcmlowk marked this pull request as ready for review July 11, 2024 10:25
@thbcmlowk thbcmlowk requested a review from a team as a code owner July 11, 2024 10:25
SdgJlbl
SdgJlbl approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM
do we want to test that this mechanism is working more permanently? By reusing a secret created independently on one of the dev instance, for example?

@thbcmlowk
Copy link
Contributor Author

Thanks, LGTM do we want to test that this mechanism is working more permanently? By reusing a secret created independently on one of the dev instance, for example?

Yes, this is planned! Alpha chart version is already available in prevision. Stay tuned!

@thbcmlowk thbcmlowk merged commit 68b1ead into main Jul 12, 2024
12 of 13 checks passed
@thbcmlowk thbcmlowk deleted the chore/existing-secret-redis branch July 12, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thbcmlowk @Owlfred @SdgJlbl