Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(charts): disable localstack services #955

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

thbcmlowk
Copy link
Contributor

@thbcmlowk thbcmlowk commented Jul 16, 2024

Description

Closes FL-1663

How has this been tested?

Before

curl http://localhost:4566/_localstack/health
{"services": {"acm": "available", "apigateway": "available", "cloudformation": "available", "cloudwatch": "available", "config": "available", "dynamodb": "available", "dynamodbstreams": "available", "ec2": "available", "es": "available", "events": "available", "firehose": "available", "iam": "available", "kinesis": "available", "kms": "available", "lambda": "available", "logs": "available", "opensearch": "available", "redshift": "available", "resource-groups": "available", "resourcegroupstaggingapi": "available", "route53": "available", "route53resolver": "available", "s3": "available", "s3control": "available", "scheduler": "available", "secretsmanager": "available", "ses": "available", "sns": "available", "sqs": "available", "ssm": "available", "stepfunctions": "available", "sts": "available", "support": "available", "swf": "available", "transcribe": "available"}, "edition": "community", "version": "3.5.1.dev"}

After

curl http://localhost:4566/_localstack/health
{"services": {"acm": "disabled", "apigateway": "disabled", "cloudformation": "disabled", "cloudwatch": "disabled", "config": "disabled", "dynamodb": "disabled", "dynamodbstreams": "disabled", "ec2": "disabled", "es": "disabled", "events": "disabled", "firehose": "disabled", "iam": "disabled", "kinesis": "disabled", "kms": "disabled", "lambda": "disabled", "logs": "disabled", "opensearch": "disabled", "redshift": "disabled", "resource-groups": "disabled", "resourcegroupstaggingapi": "disabled", "route53": "disabled", "route53resolver": "disabled", "s3": "available", "s3control": "disabled", "scheduler": "disabled", "secretsmanager": "disabled", "ses": "disabled", "sns": "disabled", "sqs": "disabled", "ssm": "disabled", "stepfunctions": "disabled", "sts": "disabled", "support": "disabled", "swf": "disabled", "transcribe": "disabled"}, "edition": "community", "version": "3.5.1.dev"}

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Copy link

linear bot commented Jul 16, 2024

@thbcmlowk thbcmlowk changed the title Chore/disable localstack services chore(charts): disable localstack services Jul 16, 2024
@thbcmlowk thbcmlowk marked this pull request as ready for review July 16, 2024 07:01
@thbcmlowk thbcmlowk requested a review from a team as a code owner July 16, 2024 07:01
@thbcmlowk thbcmlowk force-pushed the chore/disable-localstack-services branch from c4ffe1b to 9cfc365 Compare July 16, 2024 07:06
@thbcmlowk
Copy link
Contributor Author

/e2e

@Owlfred
Copy link

Owlfred commented Jul 16, 2024

End to end tests: ✔️ SUCCESS

@guilhem-barthes
Copy link
Contributor

Do we have a benchmark on memory use after deactivating unnecessary services?

@thbcmlowk
Copy link
Contributor Author

thbcmlowk commented Jul 16, 2024

Do we have a benchmark on memory use after deactivating unnecessary services?

We do not.

This PR patches a configuration that did not seem to work as expected. Assessing the impact of deactivating such services, in particular in regards of memory consumption is a follow-up task IMHO.

@thbcmlowk
Copy link
Contributor Author

Do we have a benchmark on memory use after deactivating unnecessary services?

We do not.

This PR patches a configuration that did not seem to work as expected. Assessing the impact of deactivating such services, in particular in regards of memory consumption is a follow-up task IMHO.

Created FL-1665

@thbcmlowk thbcmlowk force-pushed the chore/disable-localstack-services branch from 9cfc365 to ca3d96c Compare July 22, 2024 07:38
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk force-pushed the chore/disable-localstack-services branch from ca3d96c to ead6f2d Compare July 22, 2024 12:45
@thbcmlowk thbcmlowk merged commit c26f6cc into main Jul 22, 2024
10 checks passed
@thbcmlowk thbcmlowk deleted the chore/disable-localstack-services branch July 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants