Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependencies #957

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore: remove unused dependencies #957

merged 1 commit into from
Jul 18, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jul 18, 2024

No description provided.

@SdgJlbl SdgJlbl requested a review from a team as a code owner July 18, 2024 07:52
@SdgJlbl SdgJlbl force-pushed the chore/remove-unused-dep branch from 81a6692 to fec57bc Compare July 18, 2024 07:55
@Substra Substra deleted a comment from Owlfred Jul 18, 2024
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watchdog provides watchmedo, which is used when settings: is different than prod

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 18, 2024

watchdog provides watchmedo, which is used when settings: is different than prod

for skaffold, right?
do we want to keep it in requirements.txt or should it be in dev-requirements.txt?

@SdgJlbl SdgJlbl force-pushed the chore/remove-unused-dep branch from fec57bc to 8f1944f Compare July 18, 2024 08:20
@Substra Substra deleted a comment from Owlfred Jul 18, 2024
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 18, 2024

watchdog provides watchmedo, which is used when settings: is different than prod

for skaffold, right? do we want to keep it in requirements.txt or should it be in dev-requirements.txt?

OK, it's actually used in the CI so I think it won't work if it's in the dev requirements. Reverted the change, thanks for the review 👍

@Substra Substra deleted a comment from Owlfred Jul 18, 2024
@SdgJlbl SdgJlbl force-pushed the chore/remove-unused-dep branch from 8f1944f to 34d4571 Compare July 18, 2024 08:23
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 18, 2024

/e2e --tests=sdk,substrafl

@Owlfred
Copy link

Owlfred commented Jul 18, 2024

End to end tests: ✔️ SUCCESS

“To infinity and beyond!” ― Buzz Lightyear, Toy Story

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl force-pushed the chore/remove-unused-dep branch from 34d4571 to 9fea894 Compare July 18, 2024 08:48
@SdgJlbl SdgJlbl requested a review from guilhem-barthes July 18, 2024 08:52
@SdgJlbl SdgJlbl enabled auto-merge (squash) July 18, 2024 08:55
@SdgJlbl SdgJlbl merged commit 79e34e9 into main Jul 18, 2024
7 checks passed
@SdgJlbl SdgJlbl deleted the chore/remove-unused-dep branch July 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants