chore: remove tqdm #990
Merged
chore: remove tqdm #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend/image_transfer/encoder.py
Outdated
| @@ -23,6 +23,8 @@ | |||
| from substrapp.docker_registry import RegistryPreconditionFailedException | |||
| from substrapp.utils import safezip | |||
|
|
|||
| logger = structlog.get_logger("events") | |||
There was a problem hiding this comment.
Why is it in the events logger? Shouldn't be builder?
There was a problem hiding this comment.
my bad thanks for catching this
guilhem-barthes
approved these changes
Sep 5, 2024
changes/990.removed
Outdated
| @@ -0,0 +1 @@ | |||
| `tqdm`dependency, only used in logging | |||
There was a problem hiding this comment.
Suggested change
| `tqdm`dependency, only used in logging | |
| `tqdm` dependency, only used in logging |
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
chore/remove-tqdm
branch
from
0e5d9ef
to
1bf0d35
Compare
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes FL-1669