This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Chaincode Pagination with query[Asset]s. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Kelvin-M
force-pushed
the
chaincode-pagination
branch
from
99cb2b2
to
a1a9978
Compare
AurelienGasser
force-pushed
the
chaincode-pagination
branch
2 times, most recently
from
2af5e83
to
d5139b0
Compare
|
@Kelvin-M I moved to a simpler For the I also made sure smart contracts that support bookmarks always return a bookmark in the chaincode response: {
result interface{}
bookmark string
}even when the bookmark is Lastly I added 2 unit tests:
I had to make changes to the mock stub to support pagination. Please let me know if all that looks good to you. |
Kelvin-M
force-pushed
the
chaincode-pagination
branch
from
d5139b0
to
373fbb4
Compare
Kelvin-M
requested review from
AurelienGasser,
CamilleMariniSonos,
inelgnu,
samlesu and
thibaultrobert
as code owners
AurelienGasser
approved these changes
Nov 30, 2020
Comment on lines
+100
to
+105
| if len(args) > 1 { | ||
| err = errors.BadRequest("incorrect number of arguments, expecting at most one argument") | ||
| return | ||
| } | ||
| elementsKeys, err := db.GetIndexKeys("aggregateAlgo~owner~key", []string{"aggregateAlgo"}) | ||
|
|
||
| if len(args) == 1 && args[0] != "" { |
There was a problem hiding this comment.
Same here and others following that I will not comment on.
Kelvin-M
force-pushed
the
chaincode-pagination
branch
from
373fbb4
to
61da986
Compare
thibaultrobert
approved these changes
Dec 7, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to add chaincode pagination for query[Asset]s.
It's based on :
Closes issue(s)
None
Companion PRs
Substra/substra-backend#352
How to test / repro
Launch e2e tests, no regression should appear.
Screenshots / Trace
None
Changes include
GetStateByPartialCompositeKeyWithPaginationinstead ofGetStateByPartialCompositeKeyChecklist
Other comments