This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
[permissions] Do not fetch node on public permissions #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblottiere
requested review from
AurelienGasser,
CamilleMariniSonos,
inelgnu,
samlesu and
thibaultrobert
as code owners
This patch keeps the existing behavior while updating the logic so that the nodes are only checked when needed. Basically, instead of iterating over nodeIds and always skipping, it now only iterate when Process.Public is false.
mblottiere
force-pushed
the
newperm-skip-nodes
branch
from
ca21f99
to
94bbfe8
Compare
AurelienGasser
approved these changes
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch keeps the existing behavior while updating the logic so
that the nodes are only checked when needed.
Basically, instead of iterating over nodeIds and always skipping, it
now only iterate when Process.Public is false.