chore: rename algo to function #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2023
ThibaultFy
force-pushed
the
rename-algo-to-function
branch
from
3567350
to
e2e0aa5
Compare
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
ThibaultFy
force-pushed
the
rename-algo-to-function
branch
from
e2e0aa5
to
ee38e47
Compare
| @@ -83,7 +83,7 @@ | |||
| # | |||
| # - Data cannot be seen once it's registered on the platform. | |||
| # - Metadata are visible by all the users of a channel. | |||
| # - Permissions allow you to execute an algorithm on a certain dataset. | |||
| # - Permissions allow you to execute an functionrithm on a certain dataset. | |||
There was a problem hiding this comment.
Suggested change
| # - Permissions allow you to execute an functionrithm on a certain dataset. | |
| # - Permissions allow you to execute a function on a certain dataset. |
| @@ -5,14 +5,14 @@ In Substra, users create tasks that are registered to the platform, then execute | |||
|
|
|||
| A task needs a valid Dockerfile to create a container and expose a command line interface. The execution of the command creates the expected output files. | |||
|
|
|||
| For example, an algo defines a list of inputs and outputs. At the task execution, the inputs files are given to the container, the paths to the files are given as arguments to the command line, and the task is responsible for creating the output files. | |||
| For example, an function defines a list of inputs and outputs. At the task execution, the inputs files are given to the container, the paths to the files are given as arguments to the command line, and the task is responsible for creating the output files. | |||
There was a problem hiding this comment.
Suggested change
| For example, an function defines a list of inputs and outputs. At the task execution, the inputs files are given to the container, the paths to the files are given as arguments to the command line, and the task is responsible for creating the output files. | |
| For example, a function defines a list of inputs and outputs. At the task execution, the inputs files are given to the container, the paths to the files are given as arguments to the command line, and the task is responsible for creating the output files. |
| # =========== | ||
| # An algorithm specifies the method to train a model on a dataset or the method to aggregate models. | ||
| # Concretely, an algorithm corresponds to an archive (tar or zip file) containing: | ||
| # An functionrithm specifies the method to train a model on a dataset or the method to aggregate models. |
There was a problem hiding this comment.
Suggested change
| # An functionrithm specifies the method to train a model on a dataset or the method to aggregate models. | |
| # A function specifies the method to train a model on a dataset or the method to aggregate models. |
| # An algorithm specifies the method to train a model on a dataset or the method to aggregate models. | ||
| # Concretely, an algorithm corresponds to an archive (tar or zip file) containing: | ||
| # An functionrithm specifies the method to train a model on a dataset or the method to aggregate models. | ||
| # Concretely, an functionrithm corresponds to an archive (tar or zip file) containing: |
There was a problem hiding this comment.
Suggested change
| # Concretely, an functionrithm corresponds to an archive (tar or zip file) containing: | |
| # Concretely, a function corresponds to an archive (tar or zip file) containing: |
Oups that come from the fact that I built the doc modifying the conf.py file... thanks for the catch, and for the review ! |
ThibaultFy
force-pushed
the
rename-algo-to-function
branch
from
b7b5437
to
8f83800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename Algo concept to Function on all the stack.
Companion PRs