Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sklearn example model initialisation #289

Merged
merged 4 commits into from
Mar 2, 2023
Merged

fix: sklearn example model initialisation #289

merged 4 commits into from
Mar 2, 2023

Conversation

ThibaultFy
Copy link
Member

No description provided.

@ThibaultFy
fix: iris example
3e06772 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy
fix: iris example
b9711fb 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy
changelog
41653c6 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
SdgJlbl
SdgJlbl approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@ThibaultFy
fix classes init
0f0bf2b 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy marked this pull request as ready for review March 2, 2023 13:49
@ThibaultFy ThibaultFy requested review from a team and RomainGoussault as code owners March 2, 2023 13:49
@ThibaultFy ThibaultFy merged commit c9ec9a4 into main Mar 2, 2023
@ThibaultFy ThibaultFy deleted the fix/sklearn_example branch March 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

@SdgJlbl SdgJlbl SdgJlbl approved these changes

@RomainGoussault RomainGoussault Awaiting requested review from RomainGoussault RomainGoussault is a code owner

@oleobal oleobal Awaiting requested review from oleobal oleobal is a code owner automatically assigned from Substra/code-owners

@Milouu Milouu Awaiting requested review from Milouu Milouu is a code owner automatically assigned from Substra/code-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @guilhem-barthes @SdgJlbl