fix: component version in binder #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
oleobal
reviewed
Apr 18, 2023
docs/source/conf.py
Outdated
| html_extra_path = [] | ||
|
|
||
| with open("additional/releases.yaml") as f: | ||
| table = yaml.safe_load(f) |
There was a problem hiding this comment.
Since it's not just used in this context anymore, I realize table isn't a very good name; maybe releases or release_info or something like that would be better.
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
ThibaultFy
requested review from
a team,
oleobal,
Milouu,
guilhem-barthes and
SdgJlbl
and removed request for
a team,
oleobal,
Milouu,
guilhem-barthes and
SdgJlbl
oleobal
reviewed
Apr 18, 2023
docs/source/conf.py
Outdated
| SUBSTRA_VERSION = "0.43.0" | ||
| TOOLS_VERSION = "0.20.0" | ||
| SUBSTRAFL_VERSION = "0.35.1" | ||
| if os.environ.get("READTHEDOCS_VERSION_TYPE") == "tag" or current_commit in tags_commit: |
There was a problem hiding this comment.
Maybe you can rely on the release table there too: if repo.commit(compat_table["releases"][0]["version"]) == repo.head.commit. But it's fine as-is IMO, it could break if we use tags for stuff other than releases but we don't.
There was a problem hiding this comment.
Yep that was my concern... One way would be to check the name of the tags to match the semver format. But with the release candidate and all it's not that obvious...
oleobal
approved these changes
Apr 18, 2023
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.