Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reorganize documentation #330

Merged
merged 10 commits into from
Aug 16, 2023
Merged

feat: reorganize documentation #330

merged 10 commits into from
Aug 16, 2023

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jul 20, 2023

The goal of this PR is to reorganise the documentation according to the Diátaxis framework to facilitate access.

TODO

  • fix Binder (missing assets dir + not installed dependencies)
  • check all links are still valid in examples

@SdgJlbl SdgJlbl force-pushed the reorganise-doc branch 4 times, most recently from 1bde999 to 084a629 Compare July 22, 2023 13:50
@SdgJlbl SdgJlbl added the open source Open source contributions (not on the roadmap) label Jul 22, 2023
@SdgJlbl SdgJlbl marked this pull request as ready for review July 22, 2023 14:00
@SdgJlbl SdgJlbl requested review from a team and RomainGoussault as code owners July 22, 2023 14:00
@SdgJlbl SdgJlbl force-pushed the reorganise-doc branch 3 times, most recently from 7267128 to cca76e0 Compare July 22, 2023 15:44
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 22, 2023

@ThibaultFy Is it expected that Binder is running all examples (and rebuilding the whole documentation) at launch time? It does not seem very scalable in the long term 🤔

Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love what you did 😍 thanks a lot for this OS contrib !!
I would love to approve but we should wait for Romain review IMO.

@RomainGoussault you should take a look at this !

Comment on lines -501 to -497
# - An :ref:`Torch algorithm<substrafl_doc/api/algorithms:Torch Algorithms>` to define the training parameters *(optimizer, train
# function, predict function, etc...)*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops.. good catch

Comment on lines 1 to 2
How-to guides for Substra developers
====================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The titles for these sections are

  • How-to guides for Substra developers
  • How-to guides for deploying Substra
  • How-to guides for Substra users

Do you think we could standardize on one formulation? such as "for developing on Substra" and "for using Substra". (unfortunately "deployers" isn't a word.. But I think it might be better to focus on action than on title)

Copy link
Contributor

@oleobal oleobal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how-to guide titles are not all standardized but IMO let's merge it as-is and address this in a separate PR

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl merged commit cef269d into main Aug 16, 2023
3 checks passed
@SdgJlbl SdgJlbl deleted the reorganise-doc branch August 16, 2023 15:31
@Milouu Milouu mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source Open source contributions (not on the roadmap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants