Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new channel explanation in main concepts #344

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

IC-1101asterisk
Copy link
Contributor

adding a new bit about channels in the main concepts
using this notion doc as source: https://www.notion.so/owkin-fdn/Substra-channels-101-ec9f2105770e4cb18a2e56ca42f533cf

Copy link
Contributor

@RomainGoussault RomainGoussault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, don't forget the changelog :)

docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
@IC-1101asterisk IC-1101asterisk force-pushed the channel-doc branch 2 times, most recently from 4d948b9 to 83a2157 Compare August 17, 2023 15:45
Copy link
Contributor

@RomainGoussault RomainGoussault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Minor comments, otherwise LGTM

docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I think we can simplify most of sentences. I did some suggestion.
Also the scheme should go were the others are stored IMO.

docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
docs/source/documentation/concepts.rst Outdated Show resolved Hide resolved
Signed-off-by: Léo-Paul HAUET <leo-paul.hauet@owkin.com>
@IC-1101asterisk IC-1101asterisk merged commit 018733f into main Aug 18, 2023
3 checks passed
@IC-1101asterisk IC-1101asterisk deleted the channel-doc branch August 18, 2023 09:14
Users only belong to one channel
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

A user can only belong to one channel. A channel has its own users, its own datasets, compute plans, tasks and functions -- all invisible to users from other channels. A user from another channel has no visibility on this. A user has no visibility on a channel they are not a part of.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit late but you have duplicates of pratically the same sentence here.

EazyAl pushed a commit to EazyAl/substra-documentation that referenced this pull request Aug 28, 2023
Signed-off-by: Léo-Paul HAUET <leo-paul.hauet@owkin.com>
Signed-off-by: EazyAl <ali.imran@owkin.com>
@Milouu Milouu mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants