-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new channel explanation in main concepts #344
Conversation
0077d28
to
a52edc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, don't forget the changelog :)
4d948b9
to
83a2157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
83a2157
to
21f579e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Minor comments, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I think we can simplify most of sentences. I did some suggestion.
Also the scheme should go were the others are stored IMO.
21f579e
to
994b36b
Compare
994b36b
to
1b246c6
Compare
Signed-off-by: Léo-Paul HAUET <leo-paul.hauet@owkin.com>
1b246c6
to
ed5766c
Compare
Users only belong to one channel | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
A user can only belong to one channel. A channel has its own users, its own datasets, compute plans, tasks and functions -- all invisible to users from other channels. A user from another channel has no visibility on this. A user has no visibility on a channel they are not a part of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit late but you have duplicates of pratically the same sentence here.
Signed-off-by: Léo-Paul HAUET <leo-paul.hauet@owkin.com> Signed-off-by: EazyAl <ali.imran@owkin.com>
adding a new bit about channels in the main concepts
using this notion doc as source: https://www.notion.so/owkin-fdn/Substra-channels-101-ec9f2105770e4cb18a2e56ca42f533cf