Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile to launch harbor as external registry #416

Merged
merged 6 commits into from
May 22, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Apr 16, 2024

Description

Describe how to start a cluster with Harbor

Fixes FL-1477 & FL-1479

Companion PR

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment :)

docs/source/how-to/developing-substra/harbor.rst Outdated Show resolved Hide resolved
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@SdgJlbl SdgJlbl force-pushed the feat/add-profile-to-launch-harbor-as-external-registry branch from 39e1d88 to c69905b Compare April 24, 2024 14:29
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@SdgJlbl SdgJlbl force-pushed the feat/add-profile-to-launch-harbor-as-external-registry branch from c69905b to f771b2c Compare April 25, 2024 09:55
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@guilhem-barthes
Copy link
Contributor Author

/e2e

@Owlfred
Copy link

Owlfred commented May 21, 2024

End to end tests: ✔️ SUCCESS

That was easy.

@SdgJlbl SdgJlbl merged commit 49a113b into main May 22, 2024
3 checks passed
@SdgJlbl SdgJlbl deleted the feat/add-profile-to-launch-harbor-as-external-registry branch May 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants