Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Pod Security Standard reference #418

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Apr 30, 2024

Fixes FL-1461

Copy link

linear bot commented Apr 30, 2024

@SdgJlbl SdgJlbl force-pushed the feat/add-pss-reference branch 2 times, most recently from d1b3847 to 1d95a3d Compare May 23, 2024 09:31
@SdgJlbl SdgJlbl marked this pull request as ready for review May 23, 2024 09:32
@RomainGoussault
Copy link
Contributor

I wouldn't put that under API reference as it's not an API reference.
To be put maybe under Substra overview?

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented May 23, 2024

I wouldn't put that under API reference as it's not an API reference. To be put maybe under Substra overview?

Good catch, I would argue to rename API reference to just Reference, or Reference guides then :)

If we stick to diátaxis guidelines, it is definitely more information-oriented than understanding-oriented, so it does not make sense to include it in the explanatory section.

@RomainGoussault
Copy link
Contributor

I wouldn't put that under API reference as it's not an API reference. To be put maybe under Substra overview?

Good catch, I would argue to rename API reference to just Reference, or Reference guides then :)

If we stick to diátaxis guidelines, it is definitely more information-oriented than understanding-oriented, so it does not make sense to include it in the explanatory section.

Reference guides looks good!

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl merged commit 415cda1 into main Jun 6, 2024
3 checks passed
@SdgJlbl SdgJlbl deleted the feat/add-pss-reference branch June 6, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants