Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add customization compute pod node #429

Merged
merged 4 commits into from
Jul 29, 2024
Merged

feat: add customization compute pod node #429

merged 4 commits into from
Jul 29, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Jul 24, 2024 •
edited
Loading

Fixes FL-1674

@guilhem-barthes guilhem-barthes force-pushed the feat/add-customization-compute-pod-node branch 5 times, most recently from 29cac13 to a471ec8 Compare July 24, 2024 11:22
@linear Linear
Copy link

linear bot commented Jul 24, 2024

FL-1674 Document use of custom `affinity`, `nodeSelectors`

@guilhem-barthes guilhem-barthes marked this pull request as ready for review July 24, 2024 13:14
@SdgJlbl
Copy link
Contributor

SdgJlbl commented Jul 24, 2024

/e2e --tests=doc

@Owlfred
Copy link

Owlfred commented Jul 24, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

SdgJlbl
SdgJlbl approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great documentation, very clear and easy to follow, with the relevant links to go further on the topic 👍
Some minor typos to fix before merge.

docs/source/how-to/deploying-substra/howto/customize-compute-pod-node.rst Outdated Show resolved Hide resolved
docs/source/how-to/deploying-substra/howto/customize-compute-pod-node.rst Outdated Show resolved Hide resolved
docs/source/how-to/deploying-substra/howto/customize-compute-pod-node.rst Outdated Show resolved Hide resolved
docs/source/how-to/deploying-substra/howto/customize-compute-pod-node.rst Outdated Show resolved Hide resolved
SdgJlbl
SdgJlbl reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also, please add a changelog fragment, thanks :)

@guilhem-barthes
doc: add first version of pod node customization
94d0eb3 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: add customize-compute-pod-node.rst to the index
fd059d8 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add terraform code for GCP configuration
0de04f8 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
fix: apply feedback
6ca4acd 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the feat/add-customization-compute-pod-node branch from 85dc4c1 to 6ca4acd Compare July 29, 2024 15:46
@guilhem-barthes guilhem-barthes merged commit 51721c3 into main Jul 29, 2024
3 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/add-customization-compute-pod-node branch July 29, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @SdgJlbl @Owlfred