-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add new compute tasks status linked to function status #297
Merged
guilhem-barthes
merged 4 commits into
main
from
feat/add-new-compute-tasks-status-linked-to-function-status
Feb 15, 2024
Merged
feat!: add new compute tasks status linked to function status #297
guilhem-barthes
merged 4 commits into
main
from
feat/add-new-compute-tasks-status-linked-to-function-status
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
requested review from
HamdyD,
jmorel and
a team
as code owners
February 15, 2024 15:01
This was referenced Feb 15, 2024
guilhem-barthes
changed the title
Feat/add new compute tasks status linked to function status
feat!: add new compute tasks status linked to function status
Feb 15, 2024
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Milouu
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
guilhem-barthes
added a commit
to Substra/orchestrator
that referenced
this pull request
Feb 15, 2024
## Companion PR - Substra/substra-backend#823 - Substra/substra-tests#319 - Substra/substra#397 - Substra/substra-frontend#297 - Substra/substra-documentation#390 ## Description <!-- Please reference issue if any. --> <!-- Please include a summary of your changes. --> Fixes of FL-1397 ## How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> ## Checklist - [x] [changelog](../CHANGELOG.md) was updated with notable changes - [ ] documentation was updated --------- Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
SdgJlbl
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
guilhem-barthes
deleted the
feat/add-new-compute-tasks-status-linked-to-function-status
branch
February 15, 2024 16:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR
Description
Fixes FL-1397
How to test
Screenshots
Notes for developers and reviewers: