Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce restricted PSS #353

Merged
merged 1 commit into from
Jun 27, 2024
Merged

chore: enforce restricted PSS #353

merged 1 commit into from
Jun 27, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jun 24, 2024

fixes fl-1610

@SdgJlbl SdgJlbl requested review from HamdyD, jmorel and a team as code owners June 24, 2024 14:15
@linear Linear
Copy link

linear bot commented Jun 24, 2024

FL-1610 Pod security context for the frontend

thbcmlowk
thbcmlowk approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks👮‍♀️! Should we run /e2e?

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jun 24, 2024

Thanks👮‍♀️! Should we run /e2e?

We can
I would also like to try out the chart on dev before merging

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jun 24, 2024

/e2e --tests=mnist,frontend

@Owlfred
Copy link

Owlfred commented Jun 24, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

guilhem-barthes
guilhem-barthes approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SdgJlbl
chore: enforce restricted PSS
c96b165 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl merged commit d2adf44 into main Jun 27, 2024
6 checks passed
@SdgJlbl SdgJlbl deleted the chore/enforce-pss branch June 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbcmlowk thbcmlowk thbcmlowk approved these changes

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

@HamdyD HamdyD Awaiting requested review from HamdyD HamdyD is a code owner

@jmorel jmorel Awaiting requested review from jmorel jmorel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SdgJlbl @Owlfred @guilhem-barthes @thbcmlowk