Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(token): disable never expiring tokens #385

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

thbcmlowk
Copy link
Contributor

@thbcmlowk thbcmlowk commented Aug 6, 2024

Description

Part of FL-1556

Companion

Substra/substra-backend#969

How to test

Screenshots

image

Notes for developers and reviewers:

  • Think to update CHANGELOG.md before merge if needed !

@thbcmlowk
Copy link
Contributor Author

/e2e --tests=mnist,camelyon,frontend --refs substra-backend=chore/disable-never-expiring-token

@Owlfred
Copy link

Owlfred commented Aug 6, 2024

End to end tests: ✔️ SUCCESS

Copy link

linear bot commented Aug 6, 2024

@thbcmlowk thbcmlowk marked this pull request as ready for review August 6, 2024 16:33
@thbcmlowk thbcmlowk requested review from HamdyD, jmorel and a team as code owners August 6, 2024 16:33
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk force-pushed the chore/disable-never-expiring-token branch from 208cac2 to 5a9a355 Compare August 14, 2024 15:14
@thbcmlowk
Copy link
Contributor Author

/e2e --tests=mnist,camelyon,frontend --refs substra-backend=chore/disable-never-expiring-token

@Owlfred
Copy link

Owlfred commented Aug 14, 2024

End to end tests: ✔️ SUCCESS

@thbcmlowk thbcmlowk merged commit 814797e into main Aug 19, 2024
3 checks passed
@thbcmlowk thbcmlowk deleted the chore/disable-never-expiring-token branch August 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants