Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove directories creation #100

Merged
merged 5 commits into from
Jul 4, 2024
Merged

chore: remove directories creation #100

merged 5 commits into from
Jul 4, 2024

Conversation

ThibaultFy
Copy link
Member

No description provided.

@ThibaultFy
chore: remove directories creation
31c9eb1 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
Copy link
Member Author

/e2e --tests substrafl, mnist, camelyon

@Owlfred
Copy link

Owlfred commented Jul 3, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@ThibaultFy
chore: remove directories creation
8c3b711 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
chore: remove directories creation
4e91120 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
chore: refacto workspace
5e4407a 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
Copy link
Member Author

/e2e --tests substrafl, mnist, camelyon

@Owlfred
Copy link

Owlfred commented Jul 3, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@ThibaultFy ThibaultFy marked this pull request as ready for review July 3, 2024 14:41
@ThibaultFy ThibaultFy requested a review from a team as a code owner July 3, 2024 14:41
@ThibaultFy
chore: changelog
66f8f18 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
thbcmlowk
thbcmlowk reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did we test that both in local and docker mode?

@ThibaultFy
Copy link
Member Author

Did we test both in local and docker mode?

Yes I did :)

thbcmlowk
thbcmlowk approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ThibaultFy ThibaultFy merged commit 35d32ee into main Jul 4, 2024
6 checks passed
@ThibaultFy ThibaultFy deleted the chore/stop-trying-to-create-directories branch July 4, 2024 11:59
@thbcmlowk
Copy link
Contributor

/e2e --tests=mnist,camelyon

@Owlfred
Copy link

Owlfred commented Jul 15, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Congratulations!

@thbcmlowk thbcmlowk restored the chore/stop-trying-to-create-directories branch July 15, 2024 14:11
@thbcmlowk thbcmlowk deleted the chore/stop-trying-to-create-directories branch September 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbcmlowk thbcmlowk thbcmlowk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @thbcmlowk