Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add python 3.11 support #85

Merged
merged 3 commits into from
Sep 25, 2023
Merged

chore: add python 3.11 support #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
767ee86
chore: rebase
ThibaultFy Sep 25, 2023
15414aa
chore: typo
ThibaultFy Sep 25, 2023
b40cd62
chore: changelog
ThibaultFy Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish_docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
outputs:
# Add a version to this list to automatically build Dockerfiles from it for the next releases
default_cuda_images: '["nvidia/cuda:11.8.0-base-ubuntu22.04"]'
default_python_versions: '["3.8", "3.9", "3.10"]'
default_python_versions: '["3.8", "3.9", "3.10", "3.11"]'
steps:
- run: true

Expand All @@ -51,7 +51,7 @@ jobs:
if [ $SUBSTRA_TOOLS_REF = "main" ]; then
echo "IMG_BASE_TAG=latest-$CUDA_IMAGE_TAG-python${{ matrix.python_version }}" >> $GITHUB_ENV
# Set the most recent image to latest
if [ "${{ matrix.cuda_image }}" == "nvidia/cuda:11.8.0-base-ubuntu22.04" ] && [ "${{ matrix.python_version }}" == "3.10" ]; then
if [ "${{ matrix.cuda_image }}" == "nvidia/cuda:11.8.0-base-ubuntu22.04" ] && [ "${{ matrix.python_version }}" == "3.11" ]; then
echo "LATEST_TAG=latest" >> $GITHUB_ENV
fi
else
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Support on Python 3.11 ([#85](https://github.com/Substra/substra-tools/pull/85))
- Contributing, contributors & code of conduct files (#77)

## [0.20.0](https://github.com/Substra/substra-tools/releases/tag/0.20.0) - 2022-12-19
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ARG CUDA_IMAGE=nvidia/cuda:11.8.0-base-ubuntu22.04
FROM $CUDA_IMAGE

# Modified by .github/workflows/publish_docker.yml
ARG PYTHON_VERSION=3.10
ARG PYTHON_VERSION=3.11
# TODO: find a way to parse this from the CUDA_IMAGE
# with bash string manipulation: ${CUDA_IMAGE##*-}//.
ARG DISTRO=ubuntu2204
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pip install substratools
## Pull the substra-tools Docker image

```sh
docker pull ghcr.io/substra/substra-tools:0.16.0-nvidiacuda11.8.0-base-ubuntu22.04-python3.10
docker pull ghcr.io/substra/substra-tools:0.16.0-nvidiacuda11.8.0-base-ubuntu22.04-python3.11
```

## Developers
Expand Down
Loading