Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support Python 3.12 #418

Merged
merged 3 commits into from
Jul 24, 2024
Merged

chore: support Python 3.12 #418

merged 3 commits into from
Jul 24, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jun 28, 2024

@SdgJlbl SdgJlbl requested a review from a team as a code owner June 28, 2024 09:16
@Substra Substra deleted a comment from Owlfred Jun 28, 2024
@Substra Substra deleted a comment from Owlfred Jun 28, 2024
@ThibaultFy
Copy link
Member

/e2e tests

The CI will still run in 3.11. To test it will need to create a branch on substra-ci and change the python version there I think

@SdgJlbl SdgJlbl force-pushed the chore/python3.12 branch 4 times, most recently from 8e2f3a1 to a514ad2 Compare July 4, 2024 08:23
@Substra Substra deleted a comment from Owlfred Jul 22, 2024
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 23, 2024

/e2e --tests=substrafl,sdk,mnist,camelyon --ref susbtrafl=chore/python3.12

@Owlfred
Copy link

Owlfred commented Jul 23, 2024

Something happened while processing your message: error: unknown option '--ref'
(Did you mean --refs?)

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 23, 2024

/e2e --tests=substrafl,sdk,mnist,camelyon --refs substrafl=chore/python3.12

@Owlfred
Copy link

Owlfred commented Jul 23, 2024

End to end tests: ✔️ SUCCESS

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to block but two minor comments. Thanks! 🤞

Comment on lines +138 to +143
def _tmp_is_three_nine(self):
"""Temporary helper function to remove as soon as support of Python 3.9 is dropped."""
import platform

return platform.python_version_tuple()[1] == "9"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have this in a Linear card or something to remember that we can get rid of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in the dopr-Python3.9 card

@@ -1 +1 @@
__version__ = "0.53.0"
__version__ = "0.54.0a1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not bet my life on this one, but as discussed I think that the version update is not mandatory as it will be installed from main on substrafl

Suggested change
__version__ = "0.54.0a1"
__version__ = "0.53.0"

@SdgJlbl SdgJlbl merged commit b75906e into main Jul 24, 2024
7 checks passed
@SdgJlbl SdgJlbl deleted the chore/python3.12 branch July 24, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants