-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support Python 3.12 #418
Conversation
14ded12
to
82260de
Compare
82260de
to
f116048
Compare
The CI will still run in 3.11. To test it will need to create a branch on substra-ci and change the python version there I think |
8e2f3a1
to
a514ad2
Compare
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
a514ad2
to
8072bb1
Compare
/e2e --tests=substrafl,sdk,mnist,camelyon --ref susbtrafl=chore/python3.12 |
Something happened while processing your message: error: unknown option '--ref' |
/e2e --tests=substrafl,sdk,mnist,camelyon --refs substrafl=chore/python3.12 |
End to end tests: ✔️ SUCCESS |
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to block but two minor comments. Thanks! 🤞
def _tmp_is_three_nine(self): | ||
"""Temporary helper function to remove as soon as support of Python 3.9 is dropped.""" | ||
import platform | ||
|
||
return platform.python_version_tuple()[1] == "9" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have this in a Linear card or something to remember that we can get rid of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in the dopr-Python3.9 card
@@ -1 +1 @@ | |||
__version__ = "0.53.0" | |||
__version__ = "0.54.0a1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not bet my life on this one, but as discussed I think that the version update is not mandatory as it will be installed from main on substrafl
__version__ = "0.54.0a1" | |
__version__ = "0.53.0" |
Companion PR
Substra/substra-tools#99
Substra/substra-tests#363
Substra/substrafl#226
https://github.com/owkin/substra-ci/pull/168
Substra/substra-tools#99 (comment)