Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Python 3.9 support #428

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore: drop Python 3.9 support #428

merged 1 commit into from
Sep 13, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Sep 9, 2024

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@SdgJlbl SdgJlbl requested a review from a team as a code owner September 9, 2024 13:59
ThibaultFy
ThibaultFy previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

ThibaultFy
ThibaultFy reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, missing changes in pyproject.toml

@ThibaultFy ThibaultFy dismissed their stale review September 9, 2024 15:24

Missing changes in pyproject.toml

@SdgJlbl
chore: drop Python 3.9 support
1cbf9e6 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
thbcmlowk
thbcmlowk approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SdgJlbl SdgJlbl merged commit b5c419c into main Sep 13, 2024
5 checks passed
@SdgJlbl SdgJlbl deleted the chore/drop-python3.9 branch September 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy left review comments

@thbcmlowk thbcmlowk thbcmlowk approved these changes

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SdgJlbl @guilhem-barthes @ThibaultFy @thbcmlowk