chore: centralize wait task in substrasdk #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
FL-1052 move `wait_task` & `wait_compute_plan`
ContextCurrently we have 3 imlementations to wait for compute tasks/ compute plans: SpecificationAcceptance criteriaHaving these features defined once in |
This was referenced Jun 27, 2023
ThibaultFy
reviewed
Jun 28, 2023
tests/dependency/test_dependency.py
Outdated
| @@ -142,7 +141,7 @@ def test_pypi_dependency( | |||
| function_key = self._register_function(dummy_algo_class(), algo_deps, client, session_dir) | |||
|
|
|||
| train_task = self._register_train_task(function_key, numpy_datasets[0], constant_samples[0], client) | |||
| utils.wait(client, train_task) | |||
| client.wait_task(train_task.key, raises=True) | |||
There was a problem hiding this comment.
Suggested change
| client.wait_task(train_task.key, raises=True) | |
| client.wait_task(train_task.key) |
Nitpicking but raises=True is the default
There was a problem hiding this comment.
I was thinking about that, but knowing that this is used instead of the assert, if we change the default, these tests will stop testing anything silently. But if you consider this is not a risk, happy to revert it!
There was a problem hiding this comment.
Makes sense ! lets keep it this way :)
ThibaultFy
approved these changes
Jun 29, 2023
tests/dependency/test_dependency.py
Outdated
| @@ -142,7 +141,7 @@ def test_pypi_dependency( | |||
| function_key = self._register_function(dummy_algo_class(), algo_deps, client, session_dir) | |||
|
|
|||
| train_task = self._register_train_task(function_key, numpy_datasets[0], constant_samples[0], client) | |||
| utils.wait(client, train_task) | |||
| client.wait_task(train_task.key, raises=True) | |||
There was a problem hiding this comment.
Makes sense ! lets keep it this way :)
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
…ient.wait_xxx` in tests Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
chore/centralize-wait_task-in-substrasdk
branch
from
7af0e75
to
b61f8d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
_wait,wait_taskandwait_compute_planonsubstra.Clientsubstra#368Client.wait_compute_plansubstra-documentation#327Summary
Centralize
wait_taskandwait_compute_plan, and re-use the implementation added insubstrathrough the other components.Notes
Fixes FL-1052
Please check if the PR fulfills these requirements