Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename function field of Function to archive #181

Merged
merged 5 commits into from
Feb 8, 2024
Merged

feat: rename function field of Function to archive #181

merged 5 commits into from
Feb 8, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Oct 18, 2023

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If the feature has an impact on the user experience, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification

@SdgJlbl SdgJlbl requested a review from a team as a code owner October 18, 2023 14:51
@SdgJlbl SdgJlbl changed the title feat: rename function field of Function to archive feat!: rename function field of Function to archive Oct 18, 2023
@SdgJlbl SdgJlbl force-pushed the feat/rename-function-to-archive branch from abdce21 to 9716c99 Compare October 18, 2023 14:52
ThibaultFy
ThibaultFy reviewed Oct 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@SdgJlbl SdgJlbl changed the title feat!: rename function field of Function to archive feat: rename function field of Function to archive Oct 18, 2023
@SdgJlbl SdgJlbl force-pushed the feat/rename-function-to-archive branch from 9716c99 to 7913119 Compare October 18, 2023 15:00
ThibaultFy
ThibaultFy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx :)

@SdgJlbl SdgJlbl mentioned this pull request Oct 27, 2023
Merged
4 tasks
SdgJlbl and others added 4 commits January 30, 2024 16:50
@SdgJlbl @ThibaultFy
feat: rename function field of Function to archive
4994e33 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@ThibaultFy
rebase
900fe4e 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
rebase
d7ec276 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
add indexes
ae6b064 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy force-pushed the feat/rename-function-to-archive branch from 19bddcf to ae6b064 Compare January 30, 2024 15:51
@ThibaultFy
rebase
497f2df 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy merged commit e52a249 into main Feb 8, 2024
7 checks passed
@ThibaultFy ThibaultFy deleted the feat/rename-function-to-archive branch February 8, 2024 15:38
ThibaultFy added a commit that referenced this pull request Feb 22, 2024
@SdgJlbl @ThibaultFy
feat: rename function field of Function to archive (#181)
ea68c56 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Co-authored-by: ThibaultFy <thibault.fouqueray@gmail.com>
ThibaultFy added a commit that referenced this pull request Feb 26, 2024
@SdgJlbl @ThibaultFy
feat: rename function field of Function to archive (#181)
56743c8 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Co-authored-by: ThibaultFy <thibault.fouqueray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SdgJlbl @ThibaultFy