Fix(posthtml#197): do not choke on svg error

SukkaW · May 25, 2022 · e15972a · e15972a
1 parent 9faf495
commit e15972a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/lib/modules/minifySvg.es6 b/lib/modules/minifySvg.es6
@@ -9,6 +9,18 @@ export default function minifySvg(tree, options, svgoOptions = {}) {
     tree.match({tag: 'svg'}, node => {
         let svgStr = tree.render(node, { closingSingleTag: 'slash', quoteAllAttributes: true });
         const result = svgo.optimize(svgStr, svgoOptions);
+
+        if (result.error) {
+            console.error('htmlnano fails to minify the svg:');
+            console.error(result.error);
+            if (result.modernError) {
+                console.error(result.modernError);
+            }
+
+            // We return the node as-is
+            return node;
+        }
+
         node.tag = false;
         node.attrs = {};
         // result.data is a string, we need to cast it to an array

diff --git a/test/modules/minifySvg.js b/test/modules/minifySvg.js
@@ -110,4 +110,21 @@ describe('minifySvg', () => {
             options
         );
     });
+
+    // https://github.com/posthtml/htmlnano/issues/197
+    it('shouldn\'t choke on svg errors', () => {
+        const input = `
+        <!doctype html>
+        <svg viewBox="0 0 100 100">
+            <text x="20" y="20" style="fill: black;">&cross;</text>
+        </svg>
+        `;
+        return init(
+            input,
+            input,
+            {
+                minifySvg: {}
+            }
+        );
+    });
 });