fix(windows): Recognize opamp as a config provider #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rnishtala-sumo! I'm not sure what the effort is but it might be worth looking at bringing the windows service test in our repo. This would allow us to catch this problem sooner. |
rnishtala-sumo
force-pushed
the
fix-windows-service
branch
from
9382c7e
to
932d6cb
Compare
echlebek
approved these changes
May 2, 2024
ccressent
approved these changes
May 2, 2024
rnishtala-sumo
force-pushed
the
fix-windows-service
branch
from
932d6cb
to
66ba16d
Compare
rnishtala-sumo
changed the title
|
@fguimond I have added this effort to our integration tests initiative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring upstream changes to the windows service
Related issue: open-telemetry/opentelemetry-collector#9516