Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to override sidecar configuration #551

Merged
merged 21 commits into from
Jul 4, 2023
Merged

feat: allow to override sidecar configuration #551

merged 21 commits into from
Jul 4, 2023

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Jun 27, 2023 •
edited
Loading

Add configuration which allows to specify configMap with tailing sidecar configuration and path to mount it:

sidecar:
  # Overrides the sidecar configuration
  config:
    mountPath: /fluent-bit/etc/
    content:
      file-1.conf: "file-1.conf content"
      file-2.conf: "file-2.conf content"

@sumo-drosiek sumo-drosiek force-pushed the drosiek-expose-configuration branch 2 times, most recently from adb85d1 to 2891a6e Compare June 28, 2023 11:46
@sumo-drosiek sumo-drosiek marked this pull request as ready for review June 28, 2023 11:53
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner June 28, 2023 11:53
@sumo-drosiek sumo-drosiek force-pushed the drosiek-expose-configuration branch 2 times, most recently from 208b93b to e763236 Compare June 29, 2023 12:08
swiatekm
swiatekm reviewed Jun 30, 2023
View reviewed changes
operator/handler/handler.go Outdated Show resolved Hide resolved
operator/handler/handler.go Show resolved Hide resolved
operator/handler/handler.go Outdated Show resolved Hide resolved
operator/handler/handler.go Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-expose-configuration branch from 7157e60 to cbde34e Compare July 3, 2023 11:02
Dominik Rosiek added 14 commits July 3, 2023 13:11
feat(operator): expose sidecar configuration
edfe558 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
feat(helm): expose sidecar configuration
f22155a 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
tests(operator): add e2e tests
a6cdb10 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
chore: set default mountPath
72f8bfa 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
tests(e2e): fix test with custom configuration
30e6c07 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
refactor: use const for volume mount name
7ed1681 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
docs: add information how to override sidecar configuration
8fad518 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
feat: use configMap as exemplar for all namespaces
4f35127 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
fix: fix rebase
a4e0737 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
refactor: move configmap to values
bb7c33f
tests: fix e2e
b70514e 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
chor: install kuttl in vagrant
b4d030f 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
refactor(operator): move deletion logic to new function
6b3ec7c 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
tests: adjust e2e test for custom configuration
0dac1c5 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-expose-configuration branch from cbde34e to 0dac1c5 Compare July 3, 2023 11:13
Dominik Rosiek added 4 commits July 3, 2023 15:04
feat(helm): update clusterRole to support configmaps management
fbc6c0a 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
tests: fix sidecar test for custom configuration test
4f3f55e 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
tests: remove resource requests
2ec06bf 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
tests: set resources to 0
24803e6 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-expose-configuration branch from b7f042d to 93972f0 Compare July 3, 2023 14:33
feat(helm): make sidecar configuration optional
4fad40f 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
chore(helm): use empty for conditional checks in templates
47b34ef 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-expose-configuration branch from 93972f0 to 47b34ef Compare July 4, 2023 06:25
@sumo-drosiek sumo-drosiek requested a review from swiatekm July 4, 2023 07:39
docs: update overriding tailing sidecar configuration
2a573bc 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek merged commit d0f16a3 into main Jul 4, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-expose-configuration branch July 4, 2023 09:40
This was referenced Jul 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumo-drosiek @swiatekm