You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see in #106 that the shapely dependency is planned to be dropped in the future -- will that be happening in the near future? If it might be a while, what do you think about wrapping shapely imports in a try/except and raising a new error with a helpful hint about installing shapely from conda instead of pip? If that sounds like a good idea, I'm happy to open a PR -- it might be as simple as just adding something like this at the top of __init__.py, or it might need it everywhere shapely is imported, not sure:
try:
importshapelyexceptOSError:
# can't use "raise from" here because py2.7 doesn't support it. Or drop 2.7 support, see #107raiseImportError("Something helpful about conda vs pip for shapely")
The text was updated successfully, but these errors were encountered:
@kanderso-nrel thanks so much for your message and for tracking all these user issues, I had no idea it was such a big problem for people. Unfortunately I don't have any time to work on dropping the shapely dependency, but I do very much welcome any contributions that can make things easier for users. So please feel free to open a PR and I will happily review it!
Something in the top __init__.py file would be good enough for me.
Installing shapely from pip instead of conda is a frequent roadblock for users that haven't been exposed to binary python dependencies:
I see in #106 that the shapely dependency is planned to be dropped in the future -- will that be happening in the near future? If it might be a while, what do you think about wrapping shapely imports in a try/except and raising a new error with a helpful hint about installing shapely from conda instead of pip? If that sounds like a good idea, I'm happy to open a PR -- it might be as simple as just adding something like this at the top of
__init__.py
, or it might need it everywhere shapely is imported, not sure:The text was updated successfully, but these errors were encountered: