Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: raise a more informative message when geos_c.dll isn't found #109

Closed
kandersolar opened this issue Feb 4, 2021 · 1 comment · Fixed by #110
Closed
Labels
enhancement New feature or request
Milestone

Comments

@kandersolar
Copy link
Contributor

Installing shapely from pip instead of conda is a frequent roadblock for users that haven't been exposed to binary python dependencies:

I see in #106 that the shapely dependency is planned to be dropped in the future -- will that be happening in the near future? If it might be a while, what do you think about wrapping shapely imports in a try/except and raising a new error with a helpful hint about installing shapely from conda instead of pip? If that sounds like a good idea, I'm happy to open a PR -- it might be as simple as just adding something like this at the top of __init__.py, or it might need it everywhere shapely is imported, not sure:

try:
    import shapely
except OSError:
    # can't use "raise from" here because py2.7 doesn't support it.  Or drop 2.7 support, see #107
    raise ImportError("Something helpful about conda vs pip for shapely") 
@anomam
Copy link
Contributor

anomam commented Feb 4, 2021

@kanderso-nrel thanks so much for your message and for tracking all these user issues, I had no idea it was such a big problem for people. Unfortunately I don't have any time to work on dropping the shapely dependency, but I do very much welcome any contributions that can make things easier for users. So please feel free to open a PR and I will happily review it!

Something in the top __init__.py file would be good enough for me.

@anomam anomam added the enhancement New feature or request label Feb 4, 2021
@anomam anomam added this to the v1.4.2 milestone Feb 5, 2021
anomam pushed a commit that referenced this issue Feb 5, 2021
Closes #109

* add import check to __init__.py

* add commentary to installation docs

* spelling error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants