Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create timeseries ground elements #80

Merged
merged 16 commits into from
Oct 24, 2019
Merged

Create timeseries ground elements #80

merged 16 commits into from
Oct 24, 2019

Conversation

anomam
Copy link
Contributor

@anomam anomam commented Oct 9, 2019 •
edited
Loading

  • create new TsGroundElement class that will represent each timeseries ground element, and which will be able to provide all its sub-surfaces defined by the cut points
  • make sure that the new class works with the current full mode
  • this is a necessary step towards the vectorization of the full mode
  • all existing tests should pass

anomam added 3 commits October 8, 2019 18:55
New class for timeseries ground element
1660816 
* the ground element will have a fixed number of surfaces, dependent on how many
cut pts there are on the ground
* wrote method to create all the surfaces, still need private methods
Turn length of TsLineCoords into properties because coords change
9980202 
* otherwise when coords are updated, the length is wrong
Make TsGround use TsGroundElement instead of TsSurface, WIP
fc36ae7
@anomam anomam added the WIP Work in progress label Oct 9, 2019
@anomam anomam self-assigned this Oct 9, 2019
@anomam anomam removed the WIP Work in progress label Oct 24, 2019
@anomam anomam merged commit 25af14a into master Oct 24, 2019
@anomam anomam deleted the ts_ground_elements branch October 24, 2019 09:16
@anomam anomam mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anomam anomam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anomam