-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functionality fix #38
base: main
Are you sure you want to change the base?
Conversation
@@ -4,7 +4,11 @@ import renderMarkdown from "../markdownRender"; | |||
|
|||
function DailyItem(props: any) { | |||
var text_html = renderMarkdown(props.daily_text); | |||
var note_html = renderMarkdown(props.daily_notes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not var note_html = ""
instead of deleting this line?
@@ -4,7 +4,11 @@ import renderMarkdown from "../markdownRender"; | |||
|
|||
function DailyItem(props: any) { | |||
var text_html = renderMarkdown(props.daily_text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add handling of this variable as well, if the props are empty?
@@ -3,7 +3,12 @@ import renderMarkdown from "../markdownRender"; | |||
|
|||
function HabitItem(props: any) { | |||
let habit_text = renderMarkdown(props.habit_text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add handling of this variable as well, if the props are empty?
@@ -3,7 +3,12 @@ import renderMarkdown from "../markdownRender"; | |||
|
|||
function RewardItem(props: any) { | |||
let reward_text = renderMarkdown(props.reward_text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add handling of this variable as well, if the props are empty?
@@ -6,7 +6,12 @@ import moment from "moment"; | |||
function TodoItem(props: any) { | |||
var dueDate = (props.dueDate==null)?"":("Due Date:"+(moment(props.dueDate).format(props.dueDateFormat))); | |||
var text_html = renderMarkdown(props.todo_text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add handling of this variable as well, if the props are empty?
Thank you for your contribution @shaineoneal ! I've left some comments, do check them out! |
Not sure if this was just an issue for me, but I think it was because the notes were set to
null
and it was looking for a string.