functionality fix #38
Open
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperChamp234
requested changes
Aug 12, 2024
| @@ -4,7 +4,11 @@ import renderMarkdown from "../markdownRender"; | |||
|
|
|||
| function DailyItem(props: any) { | |||
| var text_html = renderMarkdown(props.daily_text); | |||
| var note_html = renderMarkdown(props.daily_notes); | |||
There was a problem hiding this comment.
Why not var note_html = "" instead of deleting this line?
| @@ -4,7 +4,11 @@ import renderMarkdown from "../markdownRender"; | |||
|
|
|||
| function DailyItem(props: any) { | |||
| var text_html = renderMarkdown(props.daily_text); | |||
There was a problem hiding this comment.
Can you add handling of this variable as well, if the props are empty?
| @@ -3,7 +3,12 @@ import renderMarkdown from "../markdownRender"; | |||
|
|
|||
| function HabitItem(props: any) { | |||
| let habit_text = renderMarkdown(props.habit_text); | |||
There was a problem hiding this comment.
Can you add handling of this variable as well, if the props are empty?
| @@ -3,7 +3,12 @@ import renderMarkdown from "../markdownRender"; | |||
|
|
|||
| function RewardItem(props: any) { | |||
| let reward_text = renderMarkdown(props.reward_text); | |||
There was a problem hiding this comment.
Can you add handling of this variable as well, if the props are empty?
| @@ -6,7 +6,12 @@ import moment from "moment"; | |||
| function TodoItem(props: any) { | |||
| var dueDate = (props.dueDate==null)?"":("Due Date:"+(moment(props.dueDate).format(props.dueDateFormat))); | |||
| var text_html = renderMarkdown(props.todo_text); | |||
There was a problem hiding this comment.
Can you add handling of this variable as well, if the props are empty?
|
Thank you for your contribution @shaineoneal ! I've left some comments, do check them out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was just an issue for me, but I think it was because the notes were set to
nulland it was looking for a string.